----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68812/#review209970 -----------------------------------------------------------
Fix it, then Ship it! Please also add it to CMakeLists! src/examples/inverse_offer_framework.cpp Lines 495 (patched) <https://reviews.apache.org/r/68812/#comment294612> Let's extract it into `constexpr char FRAMEWORK_METRICS_PREFIX[]`. src/examples/inverse_offer_framework.cpp Lines 598 (patched) <https://reviews.apache.org/r/68812/#comment294613> How about pulling it into a constant, e.g., `constexpr char FRAMEWORK_NAME[]`? - Alexander Rukletsov On Sept. 23, 2018, 12:08 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68812/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2018, 12:08 a.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5827 > https://issues.apache.org/jira/browse/MESOS-5827 > > > Repository: mesos > > > Description > ------- > > Adds an example framework displaying how to handle inverse offers. > This example is based on the original review request > https://reviews.apache.org/r/50010/ by Joseph Wu. > Some changes were applied adding framework authentication > capabilites, updated PullGauge metrics and other minor adaptations > following the other example frameworks. > > > Diffs > ----- > > src/Makefile.am 5795c7097a9ed1f659e169ad81a9f2c09481aa81 > src/examples/inverse_offer_framework.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/68812/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
