----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69082/#review209994 -----------------------------------------------------------
PASS: Mesos patch 69082 was successfully built and tested. Reviews applied: `['69082']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2521/mesos-review-69082 - Mesos Reviewbot Windows On Oct. 24, 2018, 8:22 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69082/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2018, 8:22 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Alex Clemmer. > > > Repository: mesos > > > Description > ------- > > When e.g., writing to disk, errors from write might only manifest at > `::close` time. We update some instances to correctly propagate these > errors instead of dropping them silently. We only propagate the > `::close` error if the write operation succeeded, otherwise we just > propagate the error from the write operation. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/mktemp.hpp > 63b3d1a7720d07f877fa1d4eb7f32a548916637a > 3rdparty/stout/include/stout/os/write.hpp > cd35285a9595004bac627abf687588050aef8161 > 3rdparty/stout/include/stout/protobuf.hpp > 1d03e1e3a8dd642f7239d777fb04759caf100a8b > > > Diff: https://reviews.apache.org/r/69082/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
