----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69093/#review210007 -----------------------------------------------------------
src/tests/hierarchical_allocator_benchmarks.cpp Line 234 (original), 234 (patched) <https://reviews.apache.org/r/69093/#comment294644> Hm.. how were you able to change this while it remained correct? Was this just an empty map always? - Benjamin Mahler On Oct. 20, 2018, 1:27 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69093/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2018, 1:27 a.m.) > > > Review request for mesos, Benjamin Mahler and Gastón Kleiman. > > > Repository: mesos > > > Description > ------- > > Currently in the `HierarchicalAllocations_BENCHMARK_TestBase`, > it is not easy to add agents with used resources because > frameworks are created during the initialization which is > after the agent profiles creation. > > > Diffs > ----- > > src/tests/hierarchical_allocator_benchmarks.cpp > bf9167b63747f7b8a402d950947028436307082a > > > Diff: https://reviews.apache.org/r/69093/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
