----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69180/ -----------------------------------------------------------
Review request for mesos, Gastón Kleiman and Greg Mann. Bugs: MESOS-9258 https://issues.apache.org/jira/browse/MESOS-9258 Repository: mesos Description ------- This change allows clients of the /api/v1 to specify the HTTP header 'Content-Type: application/recordio' to the master's /api/v1 endpoint. For now, the only master API that will support streaming requests is the SUBSCRIBE call. Other APIs will disallow streaming. This change makes the `Master::Http::api()` function closely resemble the `Slave::Http::api()` function. The main difference is that the incoming stream reader is stored as a shared_ptr rather than a Owned object, which to prevent the stream reader from going out of scope while being passed around via lambda captures. Diffs ----- src/master/http.cpp 75ab6ea422a77e25049cd6afe007507d11650a06 src/master/master.hpp ea7e9242b62fe6c2cc0e717f9a9f2f0c1cc0a390 src/master/master.cpp 0c95c438975efd949cbf86f7d8bfea940c20a43a Diff: https://reviews.apache.org/r/69180/diff/1/ Testing ------- make See later in chain. Thanks, Joseph Wu