----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69185/#review210116 -----------------------------------------------------------
Patch looks great! Reviews applied: [69180, 69181, 69182, 69183, 69184, 69185] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 26, 2018, 12:56 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69185/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2018, 12:56 a.m.) > > > Review request for mesos, Gastón Kleiman and Greg Mann. > > > Bugs: MESOS-7974 and MESOS-9258 > https://issues.apache.org/jira/browse/MESOS-7974 > https://issues.apache.org/jira/browse/MESOS-9258 > > > Repository: mesos > > > Description > ------- > > The existing API allowed the client to send 'Accept' and 'Content-Type' > headers of 'application/json' or 'application/protobuf'. > > The SUBSCRIBE endpoint would also take a 'Content-Type' of those two > types, but always return content with 'application/recordio' (because > this is a streaming response). This maintains that behavior while > also allowing the user to use streaming headers correctly. > > > Diffs > ----- > > src/master/http.cpp 75ab6ea422a77e25049cd6afe007507d11650a06 > src/master/master.hpp ea7e9242b62fe6c2cc0e717f9a9f2f0c1cc0a390 > > > Diff: https://reviews.apache.org/r/69185/diff/1/ > > > Testing > ------- > > make > > See later in chain. > > > Thanks, > > Joseph Wu > >
