----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69194/#review210121 -----------------------------------------------------------
Ship it! Ship It! - Joseph Wu On Oct. 26, 2018, 3:34 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69194/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2018, 3:34 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5048 > https://issues.apache.org/jira/browse/MESOS-5048 > > > Repository: mesos > > > Description > ------- > > `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` is flaky > due to a race between agent restarting in the test and agent > delivering queued tasks to registered executor. If queued task is > delivered before agent restarts, an unexpected > `MesosContainerizerProcess::update()` would be triggered, thus > failing the test. This patch eliminates the race by explicitly > waiting for the `update()` call before triggering the agent restart. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 4bf0229a51b4cf60ddd84d15e84d6ce9fddd2608 > > > Diff: https://reviews.apache.org/r/69194/diff/1/ > > > Testing > ------- > > ran `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` continuously > without failure. > > > Thanks, > > Meng Zhu > >
