> On Oct. 25, 2018, 1:20 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/posix/mkdir.hpp > > Lines 67-72 (patched) > > <https://reviews.apache.org/r/69085/diff/2/?file=2102282#file2102282line68> > > > > Do we want to `fsync` directory entries which existed previously? I > > guess these could only appear unsynced if they were created by a user > > directly calling `::mkdir`, or from a external process. > > > > I'd suggest to just move this block out of the `else` (which could go > > away), and execute it unconditionally.
As discussed offline, the overhead might be high if we unconditionally do `fsync` every time. Keeping it as is and adding a comment instead. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69085/#review210033 ----------------------------------------------------------- On Oct. 24, 2018, 11:02 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69085/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2018, 11:02 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9281 > https://issues.apache.org/jira/browse/MESOS-9281 > > > Repository: mesos > > > Description > ------- > > To ensure the directories created by `mkdir` are commited to their > filesystems, an `fsync` will be called on the parent of each created > directory. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/mkdir.hpp > 418db9af310ed763a5ae4735c2ebdd1ca38738ba > > > Diff: https://reviews.apache.org/r/69085/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
