----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69203/#review210160 -----------------------------------------------------------
Patch looks great! Reviews applied: [69203] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 30, 2018, 12:46 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69203/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2018, 12:46 a.m.) > > > Review request for mesos, Meng Zhu and Qian Zhang. > > > Bugs: MESOS-9217 > https://issues.apache.org/jira/browse/MESOS-9217 > > > Repository: mesos > > > Description > ------- > > This test was incorrectly restarting the agent actor inside the test. > In the flaky test, the agent actor would be started with an auto- > generated PID (i.e. `slave(1)`, `slave(2)`, etc). Because of how this > generation works, each PID will be unique. The executor in the test > would be launched under `slave(1)` but the restarted agent would have > a PID of `slave(2)`. This meant the executor's reregistration would > fail with '404 Not Found' and the executor would be cleaned up. > > The executor cleanup would potentially trigger a TASK_LOST status > update; and if that update is sent prior to ending the test, this > will break some mock expectations and cause the test to fail. > > This changes the test to always use the same PID for the agent actor. > > > Diffs > ----- > > src/tests/gc_tests.cpp 4d94430b9de57c20f0f7fe7001a543dbf3a56f1d > > > Diff: https://reviews.apache.org/r/69203/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
