> On Oct. 24, 2018, 11:21 a.m., Joseph Wu wrote: > > We could probably do away with some of the double-negatives (i.e. `not > > UNBUNDLED` -> `BUNDLED`) in the new variable names and logic. > > Till Toenshoff wrote: > That one I would prefer to change, if needed, within a new RR as I am > strictly following the logic path enabled for libevent. I am currently trying > to remember why we chose "unbundled_...".
That's fine. Maybe `UNBUNDLED` matched the `REBUNDLED` variable used for Windows. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/#review209976 ----------------------------------------------------------- On Oct. 30, 2018, 1:20 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69140/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2018, 1:20 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, James > Peach, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Allowed for unbundled libarchive on cmake builds. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 9584f537cc2a862ce17037224fd0628ffda54b2b > 3rdparty/cmake/FindLIBARCHIVE.cmake PRE-CREATION > cmake/CompilationConfigure.cmake 5d2be0adc55ac5302c2e0e62131feb65657466be > > > Diff: https://reviews.apache.org/r/69140/diff/2/ > > > Testing > ------- > > cmake .. -DUNBUNDLED_LIBARCHIVE=ON > cmake .. -DUNBUNDLED_LIBARCHIVE=OFF > cmake .. -DUNBUNDLED_LIBARCHIVE=ON > -DLIBARCHIVE_ROOT_DIR=/usr/local/opt/libarchive > cmake .. > > > Thanks, > > Till Toenshoff > >
