----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69214/#review210191 -----------------------------------------------------------
Patch looks great! Reviews applied: [69214] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 30, 2018, 6:47 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69214/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2018, 6:47 p.m.) > > > Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Jiang Yan Xu. > > > Bugs: MESOS-8547 > https://issues.apache.org/jira/browse/MESOS-8547 > > > Repository: mesos > > > Description > ------- > > Some versions of glibc (e.g. 2.17 from CentOS 7) are hard-coded > to expect that terminal devices are owned by the tty group. This > causes containers that allocate TTYs to expect to have to chown > the TTY (see grantpt code in glibc), but it may not be possible > to launch a privileged helper to perform the chown (e.g. because > capabilities have been dropped). > > Mounting devpts with `gid=5` is the default in CentOS, Docker, > Fedora and Ubuntu, so this should not cause any compatibility > problems. > > > Diffs > ----- > > src/linux/fs.cpp 3a58bf9a44c4e1d454f3d754952705b1fd0a0b1d > > > Diff: https://reviews.apache.org/r/69214/diff/3/ > > > Testing > ------- > > sudo make check (Fedora 28) > > > Thanks, > > James Peach > >
