----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69218/#review210201 -----------------------------------------------------------
Ship it! Ship It! - Gilbert Song On Oct. 30, 2018, 3:02 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69218/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2018, 3:02 p.m.) > > > Review request for mesos, fei long and Gilbert Song. > > > Bugs: MESOS-9362 > https://issues.apache.org/jira/browse/MESOS-9362 > > > Repository: mesos > > > Description > ------- > > This patch postpones removing of `cgroups_root` until agent's recovery > is complete. Otherwise, the agent might fail to start. > > > Diffs > ----- > > src/tests/containerizer/cgroups_isolator_tests.cpp > eeaa8501058509a5f679c92aba6172e00b2003f6 > > > Diff: https://reviews.apache.org/r/69218/diff/1/ > > > Testing > ------- > > GLOG_v=1 sudo GLOG_v=1 ./src/mesos-tests > --gtest_filter=CgroupsIsolatorTest.ROOT_CGROUPS_CreateRecursively > --gtest_break_on_failure --gtest_repeat=100 --verbose > > > Thanks, > > Andrei Budnik > >
