----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69163/#review210227 -----------------------------------------------------------
PASS: Mesos patch 69163 was successfully built and tested. Reviews applied: `['69159', '69160', '68147', '69157', '69158', '69161', '69162', '69163']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2557/mesos-review-69163 - Mesos Reviewbot Windows On Oct. 25, 2018, 10:54 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69163/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2018, 10:54 a.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, and James DeFelice. > > > Bugs: MESOS-9293 > https://issues.apache.org/jira/browse/MESOS-9293 > > > Repository: mesos > > > Description > ------- > > This patch sets agent and/or resource provider ID operation status > update messages. This is not always possible, e.g., some operations > might fail validation so that no corresponding IDs can be extracted. > > Since operations failing validation are currently directly rejected by > the master without going through a status update manager, they are not > retried either. If a master status update manager for operations is > introduced at a later point it should be possible to forward > acknowledgements for updates to the master's update manager (no agent > ID, not resource provider ID). > > > Diffs > ----- > > src/common/protobuf_utils.hpp 1662125ed3e47b179ee32d08c1d3af75553066ba > src/common/protobuf_utils.cpp 2ae37ac610894652a0214022a0cf04c4365396dd > src/master/master.cpp f88c7c1f03f0de7236aad9e3bf4bfac82e91bc65 > src/resource_provider/storage/provider.cpp > db783b53558811081fb2671e005e8bbbd9edbede > src/slave/slave.cpp 74f6fb9036a9ac4f587f53ec2df04eeb4c167bfb > src/tests/slave_tests.cpp 637bedce20f63dfc1702ef549bcea8f790477be3 > > > Diff: https://reviews.apache.org/r/69163/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
