> On Oct. 25, 2018, 12:18 a.m., Benjamin Mahler wrote: > > Hm.. I don't understand what this is doing. Is this setting default > > framework behavior if someone writing a benchmark doesn't want to have to > > pass the arguments? > > Meng Zhu wrote: > That is correct.
Ok, could you update the description to clarify? It says frameworks that do not care about launching tasks, but this actually makes frameworks launch tasks by default? - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69092/#review210006 ----------------------------------------------------------- On Oct. 20, 2018, 1:27 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69092/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2018, 1:27 a.m.) > > > Review request for mesos, Benjamin Mahler and Gastón Kleiman. > > > Repository: mesos > > > Description > ------- > > For frameworks that do not care about launching tasks, we should > provide some default task launch settings to simplify the benchmark > settings. > > > Diffs > ----- > > src/tests/hierarchical_allocator_benchmarks.cpp > bf9167b63747f7b8a402d950947028436307082a > > > Diff: https://reviews.apache.org/r/69092/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
