----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69311/#review210500 -----------------------------------------------------------
Fix it, then Ship it! cmake/MesosConfigure.cmake Lines 56 (patched) <https://reviews.apache.org/r/69311/#comment295219> If I configure with `ENABLE_PARALLEL_TEST_EXECUTION=ON` and then reconfigure with `ENABLE_PARALLEL_TEST_EXECUTION=OFF`, would this line still take the old value for `TEST_DRIVER` from the cache? src/tests/CMakeLists.txt Lines 365 (patched) <https://reviews.apache.org/r/69311/#comment295220> Does this preserve user-specified `MESOS_GTEST_RUNNER_FLAGS`? Or, the other way round, will a user accidentally overwrite this when he specifies his own flags? Also, it seems a bit unfortunate to hard-code the exemption for `*ROOT_*` into the build system. intuitively I'd propose something like an advanced setting `SEQUENTIAL_TESTS` and then setting MESOS_GTEST_RUNNER_FLAGS="--sequential=${SEQUENTIAL_TESTS} $MESOS_GTEST_RUNNER_FLAGS" (I'm not sure if the above is correct CMake syntax, but you get the idea) Of course, if CMake already does the correct thing anyways, disregard this issue. - Benno Evers On Nov. 11, 2018, 12:01 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69311/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2018, 12:01 a.m.) > > > Review request for mesos, Benjamin Mahler and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Enabled parallel test runner to cmake build. > > > Diffs > ----- > > cmake/MesosConfigure.cmake de7dc08cc5ba4eaead017a97dcfeaf96bd0f4dbe > src/tests/CMakeLists.txt 553516ad66cab4480b7211950fc726b7d9a3869b > > > Diff: https://reviews.apache.org/r/69311/diff/1/ > > > Testing > ------- > > Tested as part of https://reviews.apache.org/r/69313/. > > > Thanks, > > Benjamin Bannier > >
