----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69366/#review210596 -----------------------------------------------------------
Fix it, then Ship it! The commit message talks about `profile` -- could you fix that? src/tests/mesos.hpp Lines 1795-1797 (original), 1800-1803 (patched) <https://reviews.apache.org/r/69366/#comment295307> We could rewrap this as ``` return common:: CREATE_DISK<Resource, Resource::DiskInfo::Source::Type, OperationID, Offer>( std::forward<Args>(args)...); ``` src/tests/storage_local_resource_provider_tests.cpp Lines 4323-4326 (original), 4325-4328 (patched) <https://reviews.apache.org/r/69366/#comment295308> Nit: Indented by 1 space too much? `clang-format` would have picked the old indent. - Benjamin Bannier On Nov. 16, 2018, 1:57 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69366/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2018, 1:57 a.m.) > > > Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann. > > > Repository: mesos > > > Description > ------- > > This change makes the helper more consisent with other helpers, and > can avoid one to pass in a string operation ID as a profile. > > > Diffs > ----- > > src/tests/master_slave_reconciliation_tests.cpp > 064b4d47598b1d0e18d7bef14ac62d7e5f2c1102 > src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 > src/tests/mesos.hpp 576f4bde88c069ee2fa0dd33912a034437338e7e > src/tests/operation_reconciliation_tests.cpp > 37d38b3df8c162bd1baa5ce557e54baa5c23a006 > src/tests/storage_local_resource_provider_tests.cpp > 077a46585bd56181ba199dc529e09f38f4971338 > > > Diff: https://reviews.apache.org/r/69366/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
