----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69356/#review210601 -----------------------------------------------------------
This patch breaks a number of tests. Could you make sure that they are updated with this patch or earlier? Please spell-check the commit message. src/master/validation.cpp Lines 2531-2535 (patched) <https://reviews.apache.org/r/69356/#comment295310> I wonder whether performing this validation in the master is the right thing to do. Profiles are currently applied by SLRP in the agent, so doing SLRP-specific validation here not only scatters logic in different places, but could also make making breaking changes in the future harder than necessary (agent and master are upgraded independently). Should we move this into the agent, e.g., SLRP? - Benjamin Bannier On Nov. 16, 2018, 12:55 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69356/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2018, 12:55 a.m.) > > > Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. > > > Bugs: MESOS-9275 > https://issues.apache.org/jira/browse/MESOS-9275 > > > Repository: mesos > > > Description > ------- > > Added valiadtion for `Offer.Operation.CreateDisk.target_profile`. > > > Diffs > ----- > > src/master/validation.cpp 5768ac8fe802f28855fbd7be135c711115532771 > src/tests/master_validation_tests.cpp > aa7c8f70c09459be32c6c415497e95fcdc218efd > > > Diff: https://reviews.apache.org/r/69356/diff/1/ > > > Testing > ------- > > Tests fixed later in chain. > > > Thanks, > > Chun-Hung Hsiao > >
