----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69374/#review210661 -----------------------------------------------------------
Ship it! I have made the changes listed above locally before committing. - Kevin Klues On Nov. 16, 2018, 9:36 nachm., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69374/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2018, 9:36 nachm.) > > > Review request for mesos, Benjamin Bannier and Kevin Klues. > > > Bugs: MESOS-9396 > https://issues.apache.org/jira/browse/MESOS-9396 > > > Repository: mesos > > > Description > ------- > > The integration tests for the new CLI running while building Mesos now > directly use the binary created during the build. That way we make sure > that the binary created using PyInstaller is usable, which is the > artifact that we want to distribute to users in the future. > > Previously, we were only activating the virtual environment to run the > tests thus the binary created by PyInstaller was never properly tested. > To use the binary created by PyInstaller, we simply update the PATH > before running 'mesos-cli-tests'. > > > Diffs > ----- > > src/Makefile.am c17eae4ff1d019d515f67d81821e933ecb5dc190 > src/python/cli_new/tests/CMakeLists.txt > 19119d1d1d640c10ef4ec8e245773920359ccb75 > > > Diff: https://reviews.apache.org/r/69374/diff/1/ > > > Testing > ------- > > The main test for this change is to make sure that we do not rely on the > `mesos` in `src/python/cli_new/bin/` anymore. To do so, I have followed these > steps: > > For Autotools: > ``` > $ ./bootstrap > $ mkdir build > $ cd build > $ PYTHON_3=python36 ../configure --enable-new-cli > $ make check > $ mv /home/agrillet/mesos/src/python/cli_new/bin/mesos > /home/agrillet/mesos/src/python/cli_new/bin/mesos2 > $ make check > ``` > > Then I put `/home/agrillet/mesos/src/python/cli_new/bin/mesos` back. > > For CMake: > ``` > $ ./bootstrap > $ mkdir build > $ cd build > $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON_3=python36 > $ cmake --build . --target tests > $ ctest -R CLITests -V > $ mv /home/agrillet/mesos/src/python/cli_new/bin/mesos > /home/agrillet/mesos/src/python/cli_new/bin/mesos2 > $ ctest -R CLITests -V > ``` > > > Thanks, > > Armand Grillet > >
