-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69363/
-----------------------------------------------------------
(Updated Nov. 19, 2018, 9:29 p.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Addressed Benjamin's comments and changed the order (since r/69362 depends on
this patch).
Bugs: MESOS-9275
https://issues.apache.org/jira/browse/MESOS-9275
Repository: mesos
Description (updated)
-------
This patch does the following cleanups:
1. Moved `google::protobuf::Map` equality operator to `type_utils.hpp`.
2. Moved the type helper templates for the protobuf library that do not
involve mesos protobufs into the `google::protobuf` namespaces so ADL
works appropriately.
3. Removed the type helper templates for the protobuf library from
`mesos/v1/mesos.hpp` to avoid redefinition.
Diffs (updated)
-----
include/mesos/type_utils.hpp aa61c0c88be6a885d4392b1e0dedf52150fb1e31
include/mesos/v1/mesos.hpp 452bcf2699506c15f410434100525b3ced7c4405
src/resource_provider/storage/uri_disk_profile_adaptor.cpp
6c998ef81ce369ea8677beeb3a00000c9fdbb789
Diff: https://reviews.apache.org/r/69363/diff/2/
Changes: https://reviews.apache.org/r/69363/diff/1-2/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao