----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69397/#review210772 -----------------------------------------------------------
Ship it! Ship It! - Meng Zhu On Nov. 19, 2018, 7:52 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69397/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2018, 7:52 a.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-8470 > https://issues.apache.org/jira/browse/MESOS-8470 > > > Repository: mesos > > > Description > ------- > > This patch replaces uses of `framework::validateRoles` with the more > high-level `framework::validate`. Since e.g., the master invokes > `validate` instead of directly invoking `validateRoles` this ensures > that our tests more closely match master behavior, and helps > preventing that we test code which is not invoked in reality. > > > Diffs > ----- > > src/tests/master_validation_tests.cpp > aa7c8f70c09459be32c6c415497e95fcdc218efd > > > Diff: https://reviews.apache.org/r/69397/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
