----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69400/#review210784 -----------------------------------------------------------
Fix it, then Ship it! src/examples/test_csi_plugin.cpp Line 934 (original), 922 (patched) <https://reviews.apache.org/r/69400/#comment295543> `strings::contains` src/examples/test_csi_plugin.cpp Line 952 (original), 939 (patched) <https://reviews.apache.org/r/69400/#comment295544> `error.get()` - Benjamin Bannier On Nov. 20, 2018, 12:33 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69400/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2018, 12:33 a.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-9275 > https://issues.apache.org/jira/browse/MESOS-9275 > > > Repository: mesos > > > Description > ------- > > This patch does not introduce any functional change to the test CSI > plugin. It simply refactored the check for the default mount volume > capability and the parsing of `--volumes` flag. > > > Diffs > ----- > > src/examples/test_csi_plugin.cpp 66f4ee0e2381e94bf9110d1e6e9f79eac939f683 > > > Diff: https://reviews.apache.org/r/69400/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >