----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/#review210864 -----------------------------------------------------------
src/python/cli_new/lib/cli/tests/task.py Lines 250 (patched) <https://reviews.apache.org/r/69395/#comment295665> Can we be more descriptive here? src/python/cli_new/lib/cli/tests/task.py Lines 252 (patched) <https://reviews.apache.org/r/69395/#comment295666> Comment should mention launching two tasks or something. - Kevin Klues On Nov. 26, 2018, 1:51 nachm., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69395/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2018, 1:51 nachm.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-9399 > https://issues.apache.org/jira/browse/MESOS-9399 > > > Repository: mesos > > > Description > ------- > > With this option, the command can show all the tasks that have ever been > run. This makes the command's behavior closer to the one of 'docker ps'. > > > Diffs > ----- > > src/python/cli_new/lib/cli/plugins/task/main.py > 0ce21b365d64c5c331ce7f1a5937258960e15b6f > src/python/cli_new/lib/cli/tests/task.py > eb01bf5cae095a067572f534a13f4ec542101ca5 > > > Diff: https://reviews.apache.org/r/69395/diff/4/ > > > Testing > ------- > > ``` > (mesos-cli) ? cli_new (MESOS-9399) ? mesos-cli-tests > Running the Mesos CLI unit tests > > TestAgentPlugin > test_list (cli.tests.agent.TestAgentPlugin) ... ok > > TestInfrastructure > test_capture_output (cli.tests.tests.TestInfrastructure) ... ok > test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok > > TestTaskPlugin > test_exec (cli.tests.task.TestTaskPlugin) ... ok > test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok > test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok > test_list (cli.tests.task.TestTaskPlugin) ... ok > test_list_all (cli.tests.task.TestTaskPlugin) ... ok > > ---------------------------------------------------------------------- > Ran 8 tests in 20.889s > > OK > ``` > > > Thanks, > > Armand Grillet > >
