----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69451/ -----------------------------------------------------------
(Updated Nov. 27, 2018, 11:01 p.m.) Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and Till Toenshoff. Changes ------- Addressed BenM's comments. Bugs: MESOS-9419 https://issues.apache.org/jira/browse/MESOS-9419 Repository: mesos Description (updated) ------- The `Framework::send` function assumes that either `http` or `pid` is set, which is not true for a framework that hasn't yet reregistered yet but recovered from a reregistered agent. As a result, the master would crash when a recovered executor tries to send a message to such a framework (see MESOS-9419). This patch fixes this crash bug. Diffs (updated) ----- src/master/master.hpp 3b3c1a4e61de9503c8d038dd3bee623ded5914c9 src/master/master.cpp b4b02d8b4d7d6d1aabda1f97b9bf824419f76a9e Diff: https://reviews.apache.org/r/69451/diff/2/ Changes: https://reviews.apache.org/r/69451/diff/1-2/ Testing ------- make check Thanks, Chun-Hung Hsiao