----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69454/#review210944 -----------------------------------------------------------
Ship it! Thanks for the patch, James! Could you update the commit message since this patch doesn't add a user-facing option, but rather changes a autoconf setting? Something like ``` Used POSIX.1-2001/pax tar format for distribution tarballs. ``` - Benjamin Bannier On Nov. 27, 2018, 6:51 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69454/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2018, 6:51 a.m.) > > > Review request for mesos, Benjamin Bannier and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > The default tar format used in `make dist` is v7, which only supports > paths of up to 99 bytes in length. This causes errors when building > the CentOS RPM and adding files from 3rd party packages. > > > Diffs > ----- > > configure.ac c193adf93531170fb31a31c296e3d4ae1d0300b2 > > > Diff: https://reviews.apache.org/r/69454/diff/1/ > > > Testing > ------- > > Ran `support/packaging/centos/build-rpm-docker.sh` and observed no tar errors. > > Without this change, this is what happens: > ``` > smelt:centos jpeach$ ./build-rpm-docker.sh > ... > tardir=mesos-1.8.0 && ${TAR-tar} chof - "$tardir" | GZIP=--best gzip -c > >mesos-1.8.0.tar.gz > tar: > mesos-1.8.0/3rdparty/libprocess/3rdparty/glog-0.3.3/vsprojects/logging_unittest/logging_unittest.vcproj: > file name is too long (max 99); not dumped > tar: > mesos-1.8.0/3rdparty/libprocess/3rdparty/glog-0.3.3/vsprojects/logging_unittest_static/logging_unittest_static.vcproj: > file name is too long (max 99); not dumped > ... > ``` > > > Thanks, > > James Peach > >
