----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68795/#review210960 -----------------------------------------------------------
The `PIPE` issue below is currently not a problem, since none of these ReadOnly handlers chunk their responses. src/master/http.cpp Lines 2392 (patched) <https://reviews.apache.org/r/68795/#comment295783> Micro nit: s/Note that this is/NOTE: This is/ src/master/http.cpp Lines 2401 (patched) <https://reviews.apache.org/r/68795/#comment295787> You might want to leave a note here, or elsewhere, to state that only `BODY` type Responses should be used here. When we copy the `Future<Response>` to multiple recipients, we effectively copy the `std::string body` that comprises the response text. This might also work for `PATH` type responses, but since we'd be copying the path to a file, we'd still be reading the same file twice. The `PIPE` response would be the one that should be avoided. When you copy the `Option<Pipe::Reader> reader`, this does not duplicate the stream. So multiple readers would each get separate parts of the stream, and neither would get a cohesive response (or if lucky, one reader would read everything, and the other reader(s) would get nothing). - Joseph Wu On Nov. 21, 2018, 5:20 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68795/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2018, 5:20 p.m.) > > > Review request for mesos, Alexander Rukletsov and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > This change will skip the computation of an HTTP response > for requests with the same principal, endpoint and request > headers where both requests are authenticated within the > same batching windows. > > > Diffs > ----- > > src/master/http.cpp 68ee2a6dcffbc772afec6e797b1af8da48f61937 > src/master/master.hpp 3b3c1a4e61de9503c8d038dd3bee623ded5914c9 > > > Diff: https://reviews.apache.org/r/68795/diff/3/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
