----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69472/#review211028 -----------------------------------------------------------
src/common/heartbeater.hpp Lines 40 (patched) <https://reviews.apache.org/r/69472/#comment295878> Nit: newline after open paren. src/master/framework.cpp Line 679 (original), 683 (patched) <https://reviews.apache.org/r/69472/#comment295879> Let's consider breaking the HttpConnection object out into a common implementation for master/agent, and maintaining the existing heartbeater interface which accepts a connection and a message. - Greg Mann On Nov. 28, 2018, 11:56 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69472/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2018, 11:56 p.m.) > > > Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann. > > > Bugs: MESOS-7564 > https://issues.apache.org/jira/browse/MESOS-7564 > > > Repository: mesos > > > Description > ------- > > This helper for sending heartbeats is generic enough to be used outside > of the master for other actors, like the agent, which may > need to send heartbeats of their own. > > The moved heartbeater is tweaked a little in order to remove the > dependency on the `internal::master::HttpConnection` object. > > > Diffs > ----- > > src/common/heartbeater.hpp PRE-CREATION > src/master/framework.cpp 36eda9f287bef28608024e0036db1f955a1b393c > src/master/master.hpp 3b3c1a4e61de9503c8d038dd3bee623ded5914c9 > > > Diff: https://reviews.apache.org/r/69472/diff/1/ > > > Testing > ------- > > make > > The original plan was to use the same helper for the executor too, but of the > Master, Framework, and Agent heartbeats, only the executor lacks a streaming > connection. > > > Thanks, > > Joseph Wu > >