----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69537/ -----------------------------------------------------------
Review request for mesos and James Peach. Repository: mesos Description ------- Previously, `strings::internal::format` was used. It causes issues when std::string is passed in as parameters. Switched to use `strings::format` instead in `os::shell` implementation. Diffs ----- 3rdparty/stout/include/stout/os/posix/shell.hpp de6ef23b9925c240d7621b3acd8c6b195bb1b662 3rdparty/stout/include/stout/os/windows/shell.hpp b9e06d667159d2fb5e266ce7f7e633deb1237a78 Diff: https://reviews.apache.org/r/69537/diff/1/ Testing ------- make check Thanks, Jie Yu