-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69532/
-----------------------------------------------------------
(Updated Dec. 10, 2018, 3:16 a.m.)
Review request for mesos, Andrei Budnik and James Peach.
Changes
-------
Addressed comments.
Bugs: MESOS-9462
https://issues.apache.org/jira/browse/MESOS-9462
Repository: mesos
Description
-------
Make sure that container's runtime dir has device file access. Some
Linux distributions will mount `/run` with `nodev`, restricting
accessing to device files under `/run`. However, Mesos prepares device
files for containers under container's runtime dir (which is typically
under `/run`) and bind mount into container root filesystems. Therefore,
we need to make sure those device files can be accessed by the
container. We need to do a self bind mount and remount with proper
options if necessary. See MESOS-9462 for more details.
Diffs (updated)
-----
src/linux/fs.hpp 04bd706447ec7edf6b1f05fb416c834d189b2218
src/linux/fs.cpp 6ff8b4dd8ac69f4afd5fa24bb38eb26753e6bcdd
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
c318fb956e22f07f32fd18b238b86f6a1ee0b2bf
src/slave/containerizer/mesos/isolators/volume/host_path.cpp
2e4cd2b9b852b0c95a2957f4bed33fe54f093e3d
src/slave/containerizer/mesos/launch.cpp
6aa4397aa0fc9e1c93a0f3a13fbe0a55c5a02f0c
Diff: https://reviews.apache.org/r/69532/diff/3/
Changes: https://reviews.apache.org/r/69532/diff/2-3/
Testing
-------
sudo make check
Built a new Mesos Mini image and tested. The workload runs fine. The same
workload fails on `mesos/mesos-mini-2018-12-06`
```
docker run --rm --privileged -p 5050:5050 -p 5051:5051 -p 8080:8080
jieyu/mesos-mini
```
```json
{
"id": "/test",
"cmd": "dd if=/dev/zero of=file bs=1024 count=1 oflag=dsync",
"cpus": 1,
"mem": 128,
"disk": 128,
"instances": 1,
"container": {
"type": "MESOS",
"docker": {
"image": "ubuntu:18.04"
}
}
}
```
Thanks,
Jie Yu
