----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69463/#review211140 -----------------------------------------------------------
Ship it! Ship It! - Benno Evers On Dec. 6, 2018, 12:15 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69463/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2018, 12:15 a.m.) > > > Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann. > > > Bugs: MESOS-7564 > https://issues.apache.org/jira/browse/MESOS-7564 > > > Repository: mesos > > > Description > ------- > > These new messages are meant to be backwards compatible, in that > they won't cause crashes when new executors send heartbeats to old > agents, or new agents send heartbeats to old executors. All recipients > of these heartbeats are currently expected to ignore them, as their > only purpose is to keep certain connections from being marked "stale" > by network intermediaries. > > > Diffs > ----- > > include/mesos/executor/executor.proto > 1b5fa5dab6944a8649fb98447eeec7105495b879 > include/mesos/v1/executor/executor.proto > b2ef325cf6a72137854355d541889c7c6ae7c230 > > > Diff: https://reviews.apache.org/r/69463/diff/2/ > > > Testing > ------- > > cmake --build . --target mesos-protobufs > > > Thanks, > > Joseph Wu > >
