----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69514/#review211141 -----------------------------------------------------------
Ship it! The `active_`-prefix could probably be dropped without information loss, but this is purely subjective so feel free to keep the current name if you prefer. - Benno Evers On Dec. 6, 2018, 2:21 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69514/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2018, 2:21 a.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, Gastón Kleiman, and > Greg Mann. > > > Bugs: MESOS-9258 > https://issues.apache.org/jira/browse/MESOS-9258 > > > Repository: mesos > > > Description > ------- > > This metric "master/active_operator_event_stream_subscribers" returns > the total number of subscribers to the master's operator event stream. > > > Diffs > ----- > > docs/monitoring.md 00c6ea94bcb73746aef740236632ede123f5b534 > docs/operator-http-api.md 6edf361047ee5915514da892c6d885b74a510a72 > src/master/master.cpp 3b3824a67f46866cd64e32d7f9f92484b5891aa2 > src/master/metrics.hpp f6bb89da9394bfe469bc690ff2de66824e994098 > src/master/metrics.cpp f69ed52c1c89912e7a5d26cb9409f5959b09111a > src/tests/api_tests.cpp edde48a4b4b46c9f47bc44de389c97b77322b8e8 > src/tests/master_tests.cpp ef2c00101fc3d30c564a9ca34884dece2cdd2651 > > > Diff: https://reviews.apache.org/r/69514/diff/2/ > > > Testing > ------- > > ``` > make check > > src/mesos-tests --gtest_filter="*MaxEventStreamSubscribers*" > --gtest_repeat=-1 --gtest_break_on_failure > ``` > > > Thanks, > > Joseph Wu > >
