> On Dec. 6, 2018, 12:32 a.m., Gastón Kleiman wrote: > > src/master/master.cpp > > Lines 8539-8541 (original) > > <https://reviews.apache.org/r/69505/diff/1/?file=2112071#file2112071line8539> > > > > Should we replace this with something like the following? > > > > ``` > > CHECK(!resourceProviderId.isError()) > > << "Could not determine resource provider of operation " << > > *operation > > << ": " << resourceProviderId.error(); > > ```
Good call, thanks! - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69505/#review211067 ----------------------------------------------------------- On Dec. 10, 2018, 11:01 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69505/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2018, 11:01 p.m.) > > > Review request for mesos, Benno Evers and Gastón Kleiman. > > > Bugs: MESOS-9278 > https://issues.apache.org/jira/browse/MESOS-9278 > > > Repository: mesos > > > Description > ------- > > This patch adds an operation status update manager to the > agent in order to provide reliable status updates to > schedulers for operations on agent default resources. > > Later patches will integrate this status update manager > with the agent's checkpointing/recovery code. > > > Diffs > ----- > > src/master/master.cpp ae5b24093156a6ba8ffa3e94a46e600eb4def5fa > src/slave/slave.hpp edf7269d4057ec8c95bb54c855210ad00d002a50 > src/slave/slave.cpp e13b955ffd92a8872dd513c006e96bd72e298c85 > src/tests/slave_tests.cpp 1e918712d73d0a03c4c15b41babff1f649ba9c07 > > > Diff: https://reviews.apache.org/r/69505/diff/2/ > > > Testing > ------- > > `bin/mesos-tests.sh --gtest_filter="*UpdateOperationStatusRetry*" > --gtest_repeat=-1 --gtest_break_on_failure` > > > Thanks, > > Greg Mann > >
