----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69569/#review211362 -----------------------------------------------------------
Ship it! Ship It! - Chun-Hung Hsiao On Dec. 17, 2018, 9:57 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69569/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2018, 9:57 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Bugs: MESOS-9479 > https://issues.apache.org/jira/browse/MESOS-9479 > > > Repository: mesos > > > Description > ------- > > The helper function to set up the message was set up to receive > arguments, but we missed implementing the code making use of the values. > This went undiscovered as previously only used a mock resource provider. > > > Diffs > ----- > > src/common/protobuf_utils.cpp 583f0ab0dd874602bbd20731f1f32116a425ebc4 > src/tests/master_tests.cpp 50b905b5ab508378eddf070eabfe744b68fd4cea > src/tests/storage_local_resource_provider_tests.cpp > 7887bd5ec300be3cc093886525d71b3e09bbf085 > > > Diff: https://reviews.apache.org/r/69569/diff/2/ > > > Testing > ------- > > * `make check` > * ran added test in repeatition, both with and without additional stress on > the system > > > Thanks, > > Benjamin Bannier > >
