----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69600/#review211713 -----------------------------------------------------------
Ship it! src/tests/resource_quantities_tests.cpp Lines 127 (patched) <https://reviews.apache.org/r/69600/#comment297240> Do you want to add a comment above this section of invalid cases, as done on the others? - Benjamin Mahler On Jan. 6, 2019, 7:33 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69600/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2019, 7:33 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Added parsing and insertion tests for `ResourceQuantities`. > > > Diffs > ----- > > src/Makefile.am 7a4904a3d67479267087fd2313a263d8218843fa > src/tests/CMakeLists.txt c588183e9d2b1cc733fdf3df70f37d47a5fdd7c0 > src/tests/resource_quantities_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/69600/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
