----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/#review211732 -----------------------------------------------------------
src/webui/app/agents/agent.html Lines 176-179 (patched) <https://reviews.apache.org/r/69662/#comment297310> Is this hidden if there are no providers? Can you show a screenshot of the entire agent UI rather than just a cropped version? One where there are no providers would be helpful as well (my inclination is to hide it in that case) src/webui/app/agents/agent.html Lines 184-186 (patched) <https://reviews.apache.org/r/69662/#comment297309> Do we actually expect resource providers to be providing cpus and mem? I would suggest removing these to simplify the UI Maybe at some point we want to show other resource names being provided? Maybe the column should just be 'Resources' and a stringified version is shown? - Benjamin Mahler On Jan. 4, 2019, 10:14 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69662/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2019, 10:14 a.m.) > > > Review request for mesos, Armand Grillet, Benjamin Mahler, and Chun-Hung > Hsiao. > > > Bugs: MESOS-8380 > https://issues.apache.org/jira/browse/MESOS-8380 > > > Repository: mesos > > > Description > ------- > > Displayed resource provider information in the Mesos webui. > > > Diffs > ----- > > src/webui/app/agents/agent.html a101a93dcdb95f257fe0ee967c92d2cdc1c84f84 > src/webui/app/controllers.js 8049cf611895edea7c54b3c58d71e00d823a1fd3 > > > Diff: https://reviews.apache.org/r/69662/diff/2/ > > > Testing > ------- > > `make check` > > Ran a local test with a `./src/test-csi-plugin`. > > > File Attachments > ---------------- > > Screenshot Agent screen > > https://reviews.apache.org/media/uploaded/files/2019/01/04/ed920e7b-4072-49be-8801-3b875d529fad__Screen_Shot_2019-01-04_at_11.11.51_AM.png > > > Thanks, > > Benjamin Bannier > >
