----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69705/#review211888 -----------------------------------------------------------
src/slave/state.cpp Lines 493-500 (patched) <https://reviews.apache.org/r/69705/#comment297465> All tests (including a new one) are passed after removing this code. Maybe we don't need to remove a pid file? Just return the `state`? - Andrei Budnik On Jan. 10, 2019, 2:52 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69705/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2019, 2:52 p.m.) > > > Review request for mesos, Andrei Budnik and Gilbert Song. > > > Bugs: MESOS-9501 > https://issues.apache.org/jira/browse/MESOS-9501 > > > Repository: mesos > > > Description > ------- > > After agent host is rebooted, the forked pid and libprocess pid in > agent's meta directory are obsolete, so we should not read them during > agent recovery, otherwise containerizer may wait for an irrelevant > process if the forked pid is reused by another process after reboot. > > > Diffs > ----- > > src/slave/state.hpp 4f3d4cefb3fdef29cce3a6abe4cf5db04d45301f > src/slave/state.cpp e7cf84993c74cf6da7fe22d5112e86e039780287 > > > Diff: https://reviews.apache.org/r/69705/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >