> On Jan. 11, 2019, 8:50 a.m., Qian Zhang wrote: > > src/tests/containerizer/cni_isolator_tests.cpp > > Line 138 (original), 138 (patched) > > <https://reviews.apache.org/r/69710/diff/1/?file=2119172#file2119172line138> > > > > Should we call `ContainerizerTest<MesosContainerizer>::SetUp()` instead?
Good catch! - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69710/#review211869 ----------------------------------------------------------- On Jan. 11, 2019, 5:13 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69710/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2019, 5:13 a.m.) > > > Review request for mesos, Deepak Goel, Gilbert Song, James Peach, and Qian > Zhang. > > > Bugs: MESOS-9518 > https://issues.apache.org/jira/browse/MESOS-9518 > > > Repository: mesos > > > Description > ------- > > This makes sure that cgroups for each test is independent. > > > Diffs > ----- > > src/tests/containerizer/cni_isolator_tests.cpp > eb20e637ecbe1b39e2dbb274c5198828f2fdf62f > > > Diff: https://reviews.apache.org/r/69710/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
