> On Jan. 11, 2019, 9:53 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp > > Lines 72-77 (original), 72 (patched) > > <https://reviews.apache.org/r/69715/diff/1/?file=2119178#file2119178line72> > > > > I think we still need to make sure `cniNetNs` is not `None()` if > > `CNI_COMMAND` is `ADD`.
Yeah, good point. Let me add the check - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69715/#review211875 ----------------------------------------------------------- On Jan. 11, 2019, 6:14 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69715/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2019, 6:14 a.m.) > > > Review request for mesos, Deepak Goel, Gilbert Song, and Qian Zhang. > > > Bugs: MESOS-9518 > https://issues.apache.org/jira/browse/MESOS-9518 > > > Repository: mesos > > > Description > ------- > > According CNI spec, it is possible that the container runtime does not > set CNI_NETNS environment variable when it is not available. This is > possible in scenarios like a host reboot. In that case, the CNI plugin > should do best effort cleanup, instead of failing. > > > Diffs > ----- > > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.hpp > 25f49f4b90ec6d0d55fc306b6ab324ba5b4e7403 > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp > 4e784ffb4ac29861c888fdbed4fcf9902bf4182a > > > Diff: https://reviews.apache.org/r/69715/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
