----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69727/#review211919 -----------------------------------------------------------
Very interesting. I did not find a kernel doc mentioned this semantic change. - Gilbert Song On Jan. 11, 2019, 3:21 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69727/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2019, 3:21 p.m.) > > > Review request for mesos, Deepak Goel and Gilbert Song. > > > Bugs: MESOS-9518 > https://issues.apache.org/jira/browse/MESOS-9518 > > > Repository: mesos > > > Description > ------- > > In recent versions of kernels, the device number of '/proc/<pid>/ns/net' > is different than that of '/proc'. It shows up as "nsfs" instead of > "proc" like the old kernels. For instance: > > Newer kernel: > > ``` > $ uname -nr > ubuntu-xenial 4.4.0-83-generic > $ stat -L -c %d /proc/self/ns/net > 3 > $ stat -L -c %d /proc > 4 > ``` > > Older kernel: > > ``` > $ uname -nr > core-dev 3.10.0-693.5.2.el7.x86_64 > $ stat -L -c %d /proc/self/ns/net > 3 > $ stat -L -c %d /proc > 3 > ``` > > As a result, we should compare the device number directly against the > namespace handle, instead of `/proc`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > a1130a58553fb67bd8c212498b98978f116d7b0c > > > Diff: https://reviews.apache.org/r/69727/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
