----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/#review211922 -----------------------------------------------------------
This looks good to me, but I am not a cmake expert. It would be great if Till/Joseph/Benjamin could chime in. - Gastón Kleiman On Jan. 11, 2019, 10:12 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69708/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2019, 10:12 a.m.) > > > Review request for mesos, Gastón Kleiman, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-9519 > https://issues.apache.org/jira/browse/MESOS-9519 > > > Repository: mesos > > > Description > ------- > > This patch cherry-picks an unofficial commit to disable ALPN compilation > if only OpenSSL 1.0.1 is on the system. > > NOTE: In addition to the cherry-picked commit, The whole gRPC patch is > regenerated to be in sync with https://github.com/grpc/grpc/pull/16323. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 703808d063e4bba58f647b5d48b78724003bcc4e > 3rdparty/grpc-1.10.0.patch 655f00387a6b308b653b23053419ec05c8b22144 > 3rdparty/grpc.md e06843c8b6038eb9fb809241686fd611d1daedc8 > > > Diff: https://reviews.apache.org/r/69708/diff/2/ > > > Testing > ------- > > OS=ubuntu:14.04 BUILDTOOL=cmake COMPILER=gcc CONFIGURATION='--verbose > --enable-libevent --enable-ssl' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1' > support/docker-build.sh > OS=ubuntu:16.04 BUILDTOOL=cmake COMPILER=gcc CONFIGURATION='--verbose > --enable-libevent --enable-ssl' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1' > support/docker-build.sh (to make sure that it works with OpenSSL 1.0.2. Also > manually inspected that ALPN symbols are linked). > > NOTE: The patch itself does not depend on r/69725, but the ubuntu:16.04 test > above does. > > > Thanks, > > Chun-Hung Hsiao > >
