> On Jan. 12, 2019, 8:50 p.m., Benjamin Bannier wrote: > > src/tests/api_tests.cpp > > Line 4830 (original), 4830 (patched) > > <https://reviews.apache.org/r/69726/diff/1/?file=2119270#file2119270line4830> > > > > Could you explain what in particular is broken here (e.g., by linking a > > ticket)? Resource provider managers use in memory storage for their state > > which should be fine here (e.g., no agent restart). The message you are > > quoting in the commit message is just for user information. > > > > Right now it is hard to get a grasp for what needs to be done for this > > test to be enabled again.
Interestingly, this was actually on the wrong test! (`TaskUpdatesUponAgentGone` vs. `OperationUpdatesUponAgentGone`). After some investigation it also turned out that the error is not even windows-specific, just for some reason far more likely to happen there (i.e. 2 out of 2 runs, as opposed to 0 out of ca. 20 on linux), so I reverted the disabling and included a proper fix in this review. - Benno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69726/#review211936 ----------------------------------------------------------- On Jan. 14, 2019, 4:35 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69726/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2019, 4:35 p.m.) > > > Review request for mesos, Gastón Kleiman and Greg Mann. > > > Repository: mesos > > > Description > ------- > > It could happen that the first offer was sent before the allocator > had been updated with the resources from the resource provider. > > To further increase reliability, stopped the clock during this test. > > > Diffs > ----- > > src/tests/api_tests.cpp c597243e2e210e83a4ab7441fbcfa3198b43d849 > > > Diff: https://reviews.apache.org/r/69726/diff/2/ > > > Testing > ------- > > `./src/mesos-tests --gtest_filter="*OperationUpdates*" --gtest_repeat=50000 > --gtest_throw_on_failure` > > > Thanks, > > Benno Evers > >
