----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69656/#review211962 -----------------------------------------------------------
Fix it, then Ship it! src/tests/slave_recovery_tests.cpp Lines 5152-5153 (original), 5153-5154 (patched) <https://reviews.apache.org/r/69656/#comment297542> Not terribly impactful for the test, but since you are capturing the TASK_STARTING update, you could check the status before the TASK_RUNNING one. ``` AWAIT_READY(statusStarting); EXPECT_EQ(TASK_STARTING, statusStarting->state()); ``` - Joseph Wu On Jan. 2, 2019, 9:16 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69656/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2019, 9:16 p.m.) > > > Review request for mesos, Joseph Wu and Till Toenshoff. > > > Bugs: MESOS-5048 > https://issues.apache.org/jira/browse/MESOS-5048 > > > Repository: mesos > > > Description > ------- > > `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` is flaky > due to a race between executor shutdown (due to never getting any > tasks) and the test querying resource statistics. If the executor > is shutdown before the statistics query, the test will fail. > > This patch fixes the test by explicitly waiting for the task to > be delivered and task status transition to `TASK_RUNNING` before > restarting the agent. This way, the executor will not be shutdown > after agent restart. Hence there will be no race. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 0eb47e2bdf6a46fc21b59bb85b4b89181087ccd3 > > > Diff: https://reviews.apache.org/r/69656/diff/1/ > > > Testing > ------- > > ran `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` continuously > without failure. > > > Thanks, > > Meng Zhu > >
