> On Jan. 11, 2019, 6:15 p.m., Benjamin Mahler wrote: > > Seems useful to add a bit of context to the description that these are now > > duplicated via the options struct and used through that? Did I understand > > right?
That is correct. Updated the summary. - Meng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69729/#review211932 ----------------------------------------------------------- On Jan. 11, 2019, 4:12 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69729/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2019, 4:12 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > These fields were used before we introducing the > `mesos::allocator::Options` struct. They are now > duplicated and unused. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp > b58371b5247c6a479b10b6967ef852801081e6e8 > src/master/allocator/mesos/hierarchical.hpp > a4425bc952864d6a0dacee4ae92637fd31e4a45f > > > Diff: https://reviews.apache.org/r/69729/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
