----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69658/#review211973 -----------------------------------------------------------
src/resource_provider/storage/provider.cpp Line 1211 (original), 1211 (patched) <https://reviews.apache.org/r/69658/#comment297554> This does not look right to me. The intention of the manual indexing is to skip all operation statuses that the status update manager already knows about. - Chun-Hung Hsiao On Jan. 3, 2019, 9:06 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69658/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2019, 9:06 a.m.) > > > Review request for mesos and Chun-Hung Hsiao. > > > Repository: mesos > > > Description > ------- > > This patch replaces an instance of manual indexing during iteration with > a `foreach`. We also remove an unused variable. > > This is a non-functional change. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > d6e20a549ede189c757ae3ae922ab7cb86d2be2c > > > Diff: https://reviews.apache.org/r/69658/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
