----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69588/#review212027 -----------------------------------------------------------
src/master/master.cpp Lines 3604-3605 (original), 3604-3605 (patched) <https://reviews.apache.org/r/69588/#comment297618> Isn't the empty case valid? Also, use `Resources::reservationRole`? src/master/master.cpp Line 3662 (original), 3664 (patched) <https://reviews.apache.org/r/69588/#comment297617> The `reservations.empty()` case is actually an invalid call right? There's nothing to unreserve. Should we be CHECKing that here or is that validated after this point today? src/master/master.cpp Lines 3723-3724 (original), 3723-3724 (patched) <https://reviews.apache.org/r/69588/#comment297619> Is the empty case valid? Also, use `Resources::reservationRole`? src/master/master.cpp Line 3818 (original), 3826-3829 (patched) <https://reviews.apache.org/r/69588/#comment297620> Can you use `Resources::reservationRole` for this? I guess `*` is invalid for persistent volumes but we don't care here? src/master/master.cpp Lines 3877-3880 (original), 3892-3895 (patched) <https://reviews.apache.org/r/69588/#comment297621> ditto `Resources::reservationRole` and `*` being invalid, but I guess we don't care here? src/master/master.cpp Lines 3940-3943 (original), 3959-3962 (patched) <https://reviews.apache.org/r/69588/#comment297622> Ditto `Resources::reservationRole` and `*` being invalid (but I guess we don't care here?) - Benjamin Mahler On Dec. 19, 2018, 11:20 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69588/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2018, 11:20 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Michael Park, > and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Since the master now upgrades resources to the post-reservation-refinement > format before authorization (see MESOS-7735), the authorization logic in the > master becomes outdated. This patch cleans it up. > > > Diffs > ----- > > src/master/master.cpp b4faf2b077a0288ba36195b7a21402932489d316 > > > Diff: https://reviews.apache.org/r/69588/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
