----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69612/#review212068 -----------------------------------------------------------
Fix it, then Ship it! Thanks for the cleanup, Andrei! support/mesos-gtest-runner.py Line 246 (original) <https://reviews.apache.org/r/69612/#comment297678> Any reason to not preserve the path normalization here? support/mesos-gtest-runner.py Line 282 (original), 280 (patched) <https://reviews.apache.org/r/69612/#comment297679> We could take this a step further by taking advantage of implicit bool to integer conversions, NFAILED = sum(not success, for success, _ in RESULTS) - Benjamin Bannier On Dec. 20, 2018, 5:40 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69612/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2018, 5:40 p.m.) > > > Review request for mesos, Armand Grillet and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > support/mesos-gtest-runner.py 88a60c39e32730cd2875dc97c2d85cc314255050 > > > Diff: https://reviews.apache.org/r/69612/diff/1/ > > > Testing > ------- > > make check > sudo make check > > > Thanks, > > Andrei Budnik > >
