dlazarus commented on issue #324: MESOS-9499 extended URI syntax to support any Zookeeper authentication schemes URL: https://github.com/apache/mesos/pull/324#issuecomment-454839100 > We will want to add some regression tests too, before we commit any changes. > > You can start looking/reading/familiarizing yourself with these: > https://github.com/apache/mesos/blob/master/src/tests/zookeeper.hpp > https://github.com/apache/mesos/blob/master/src/tests/zookeeper_tests.cpp > > Since you are adding additional authentication schemes, we can use the other built-in schemes which ZK provides, like `host` or `ip` for testing. > https://zookeeper.apache.org/doc/r3.1.2/zookeeperProgrammers.html#sc_BuiltinACLSchemes > We will want to add some regression tests too, before we commit any changes. > > You can start looking/reading/familiarizing yourself with these: > https://github.com/apache/mesos/blob/master/src/tests/zookeeper.hpp > https://github.com/apache/mesos/blob/master/src/tests/zookeeper_tests.cpp > > Since you are adding additional authentication schemes, we can use the other built-in schemes which ZK provides, like `host` or `ip` for testing. > https://zookeeper.apache.org/doc/r3.1.2/zookeeperProgrammers.html#sc_BuiltinACLSchemes It looks like those tests use some kind of mock implementation of Zookeeper. Because only "digest scheme" works. On my setup patched Mesos works with any schemes. Really all Mesos has to do with Zookeeper auth is to pass schema and auth data to Zookeeper. Two strings. It does not matter what inside and which particular scheme it uses. So maybe better to make unit test for URL class. Just to test parsing extracts auth data correctly from the string. Or someone needs to explain to me where is Zookeeper setup for those tests and how to change it. But IMHO it is overkill.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
