> On Jan. 19, 2019, 1:05 a.m., Gilbert Song wrote: > > src/slave/flags.cpp > > Lines 1397 (patched) > > <https://reviews.apache.org/r/68020/diff/10/?file=2117329#file2117329line1397> > > > > I would like to re-visit the naming seccomp_profile V.S. > > seccomp_profile_name. WDYT? > > > > cc @qianzhang
`seccomp_profile` suggests that its value can be a Seccomp profile. `seccomp_profile_name` emphasizes that it's not a JSON value. Note, that seccomp profile is a ~4k characters long string. Passing the whole JSON as an argument might be problematic. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68020/#review212162 ----------------------------------------------------------- On Nov. 8, 2018, 3:24 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68020/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2018, 3:24 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > `--seccomp_config_dir` and `--seccomp_profile_name` flags have been > added to the agent. These flags are used by the `linux/seccomp` > isolator to specify the path of the directory containing Seccomp > profiles and the name of the default Seccomp profile. > > > Diffs > ----- > > docs/configuration/agent.md 330283f4e3957075dd4310de4a841feac23de36c > src/slave/flags.hpp 494ae02ab5eb365e2cda5017be573691107c3f28 > src/slave/flags.cpp 6bac8e1409f04d639204c45eda8a90c098e3dbd0 > > > Diff: https://reviews.apache.org/r/68020/diff/10/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
