----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69791/#review212203 -----------------------------------------------------------
In commit message: s/atomically checkpoint/atomically checkpointing/ Also, in the commit message I would add a sentence to the end which makes it explicit that this patch doesn't update any callsites, but simply changes the helper to enable checkpointing without downgrading. - Greg Mann On Jan. 18, 2019, 10:59 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69791/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2019, 10:59 p.m.) > > > Review request for mesos, Benno Evers and Greg Mann. > > > Bugs: MESOS-9356 > https://issues.apache.org/jira/browse/MESOS-9356 > > > Repository: mesos > > > Description > ------- > > For backwards compatibility the agent currently downgrades resources > before checkpointing them. > > In order to support providing operation feedback for operation affecting > agent default resources, we're going to start atomically checkpoint > resources and operations in a new file. > > Since we're going to checkpoint the resources to a new file that is not > used by old agents, there is no need to downgrade resources before > writing them to that file. > > > Diffs > ----- > > src/slave/state.hpp e2180ae37a65a57d1edb29d2ad6cc8232029906e > > > Diff: https://reviews.apache.org/r/69791/diff/1/ > > > Testing > ------- > > Current tests still pass. > > > Thanks, > > Gastón Kleiman > >
