> On Jan. 23, 2019, 7:26 a.m., Qian Zhang wrote: > > docs/isolators/linux-seccomp.md > > Lines 44 (patched) > > <https://reviews.apache.org/r/69493/diff/6/?file=2120375#file2120375line44> > > > > <master ip>:5050 ?
I think it is just a snippet. No one will copy-paste blindly it ever. I don't want to emphasize this insignificant detail (in the context of *seccomp* configuration) as a port which is also configurable. > On Jan. 23, 2019, 7:26 a.m., Qian Zhang wrote: > > docs/isolators/linux-seccomp.md > > Lines 55 (patched) > > <https://reviews.apache.org/r/69493/diff/6/?file=2120375#file2120375line55> > > > > I think we should mention `SeccompInfo` here. >From >https://github.com/apache/mesos/blob/master/docs/isolators/linux-capabilities.md: ``` In order for a Mesos task to acquire specific effective capabilities or limit its bounding capabilities it should declare the required capabilities in the LinuxInfo element of its ContainerInfo. ``` This document has equivalent meaning in that sense. It should not be that hard for the reader to find `SeccompInfo` field in the `LinuxInfo` message. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69493/#review212225 ----------------------------------------------------------- On Nov. 30, 2018, 4:33 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69493/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2018, 4:33 p.m.) > > > Review request for mesos, Gilbert Song, James Peach, and Qian Zhang. > > > Bugs: MESOS-9036 > https://issues.apache.org/jira/browse/MESOS-9036 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/isolators/linux-seccomp.md PRE-CREATION > docs/mesos-containerizer.md d15e82583fa207ba78e9fc1e83da0cf1f469ec4e > docs/upgrades.md e493aefb36ea7b9631af35179938d778dc47442a > > > Diff: https://reviews.apache.org/r/69493/diff/6/ > > > Testing > ------- > > None: not a functional change. > > > Thanks, > > Andrei Budnik > >
