----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69775/#review212261 -----------------------------------------------------------
Patch looks great! Reviews applied: [69775] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Jan. 16, 2019, 11:07 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69775/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2019, 11:07 p.m.) > > > Review request for mesos, Andrei Budnik, Benjamin Mahler, Greg Mann, and Qian > Zhang. > > > Repository: mesos > > > Description > ------- > > LOG(FATAL) would dump a stack trace which may confuse people with > a master crash case. We should just print out an error msg. > > > Diffs > ----- > > src/master/master.cpp 2339207149a85578ea47cf66f28392182f9075f2 > > > Diff: https://reviews.apache.org/r/69775/diff/2/ > > > Testing > ------- > > N/A > > > Thanks, > > Gilbert Song > >
