----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69795/#review212257 -----------------------------------------------------------
src/slave/slave.hpp Lines 558 (patched) <https://reviews.apache.org/r/69795/#comment297987> s/checkpoint/checkpointed/ src/slave/slave.hpp Lines 563 (patched) <https://reviews.apache.org/r/69795/#comment297988> s/()()/()/ src/slave/slave.cpp Lines 7323 (patched) <https://reviews.apache.org/r/69795/#comment297989> Use `CHECK_SOME` here instead of an unguarded `.get()`. src/slave/slave.cpp Lines 7354 (patched) <https://reviews.apache.org/r/69795/#comment297992> Ditto here regarding the unguarded `.get()` src/slave/slave.cpp Lines 7356-7380 (patched) <https://reviews.apache.org/r/69795/#comment297993> If we change the checkpointing code to checkpoint the operation _before_ it is applied, then we need to apply speculative operations here as well, since `updateOperation()` only applies non-speculative operations when they transition to terminal. src/slave/slave.cpp Lines 7381-7384 (patched) <https://reviews.apache.org/r/69795/#comment297996> Should we add a `CHECK(operation->latest_status().state() == OPERATION_FINISHED)` here? - Greg Mann On Jan. 24, 2019, 12:16 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69795/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2019, 12:16 a.m.) > > > Review request for mesos, Benno Evers and Greg Mann. > > > Bugs: MESOS-9356 > https://issues.apache.org/jira/browse/MESOS-9356 > > > Repository: mesos > > > Description > ------- > > Made agent recover atomically checkpointed resources and operations. > > > Diffs > ----- > > src/slave/slave.hpp 2bcd7a93a8f25b77c71c7f931bfaac87649f987c > src/slave/slave.cpp ed92f672f5155d70a36ba3619bb6f06fa09bc836 > src/slave/state.hpp e2180ae37a65a57d1edb29d2ad6cc8232029906e > src/slave/state.cpp ae16d6f656cff71bcbdd4ffb02888024530b9274 > > > Diff: https://reviews.apache.org/r/69795/diff/3/ > > > Testing > ------- > > Current tests still pass. > > > Thanks, > > Gastón Kleiman > >
